Currently one can add subflags only to the <and></and>, <or></or>, <not></not> flags.
probably a rather minor problem in tome3 but easy to fix. I attached a patch.
I just got an unusual crash. It happened on a window re-size (max screen). I will log this as an unconfirmed bug, since I haven’t been able to duplicate this. Got this stack trace out of GDB.
Starting program: /usr/local/bin/tome3
[Thread debugging using libthread_db enabled]
[New Thread 0xb6f4a8e0 (LWP 12336)]
[New Thread 0xb2c8db70 (LWP 12339)]
[Thread 0xb2c8db70 (LWP 12339) exited]
[New Thread 0xb2c8db70 (LWP 12340)]
[New Thread 0xb248cb70 (LWP 12341)]
Program received signal SIGSEGV, Segmentation fault.
term_win_copy (s=<value optimized out>, f=<value optimized out>,
w=<value optimized out>, h=63) at z-term.c:437
437 *s_aa++ = *f_aa++;
Randomly levels are generated with an unmapped edge even though you’re standing right next to it. For example, in the ToME module, go tho the barrow downs. You’ll appear on a staircase with 6 out of nine adjacent squares visible, and the 3 map-edge squares invisible. Walking off and back on does not map them. You have to walk into them to make them visible.
I think this behavior was new with alpha 18.
The current GCC/binutils toolchain doesn’t include libraries which are linked into others autmatically, so it is now needed to add -lm to the link line.
I.e. the following patch:
— src/makefile.std 2010-04-20 10:56:18.000000000 -0400
+++ src/makefile.std.HvB 2010-04-18 19:17:39.000000000 -0400
@@ -115,7 +115,7 @@ -DSUPPORT_GAMMA \ -DUSE_PRECISE_CMOVIE \ -DUSE_UNIXSOCK
-LIBS = -lcurses -L$(X11BASE)/lib -lX11
+LIBS = -lcurses -L$(X11BASE)/lib -lX11 -lm ##
This code:
function player.make_savefile_descriptor() return anything_undefined end
Results in T-Engine loading to a blackscreen and locked condition, requiring a forced close and deletion of the relevant savefile to correct. Presumably babyface is grabbing all savefile descriptors for all modules before it displays the menu, and is failing to confirm that function returns are valid. So if one savefile in a single module has a bug...the entire engine dies.
Proposed solution: Add some error checking to babyface. T-Engine should not depend on every single module savefile to be error free to load its menu.
This code looks good. Can someone please test on windows and, if all goes well, get it into the Hg repository?
Items native to the engine are not recognized as a savable data type. For example, this code:
declare_globals {
"swag",
}
swag = {}
add_loadsave("swag", {})
local obj = create_object(tv, sv)
swag[1] = obj
will generate this error:
error: Unsavable type userdata in swag[1] stack traceback: 1: function `error' [C] 2: function `f' at line 120 [file `/engine/load2.lua'] 3: function `__savefile_recurse_one' at line 82 [file `/engine/load2.lua'] 4: function `__savefile_recurse_table' at line 95 [file `/engine/load2.lua'] 5: function `__savefile_recurse_one' at line 80 [file `/engine/load2.lua'] 6: function `__savefile_recurse' at line 73 [file `/engine/load2.lua'] 7: function <115:file `/engine/load2.lua'> at line 123
Presumably starting a new game when the player tries to load a dead character’s savefile is (convenient) intended behavior. However, it seems not to be working quite properly, because several times I have tried to load saved games with characters very much alive, only to be presented with the “new game” interface at every try. Unfortunately I have no idea what causes this, or why it only affects some of my save files.
esettings_get_int and esettings_get_str are returning the default values for things, even when I *know* that the values exist in the config file.
It seems to affect only “bar.baz = 1” things, rather than “bar_baz = 1” (i.e. esettings_get_int(”sdl.graphics.thingy”, 0) will always return 0, but esettings_get_int(”sdl.graphics_thingy”, 0) will behave correctly).
T-engine needs UI-accessible option to disable sound.
I’ve put this at High severity because it’s absolutely infuriating to not be able to disable the sound when you *really* don’t want it.